tools: enable no-proto rule for linter

Enable `no-proto` in `.eslintrc`.

Use `Object.setPrototypeOf()` and `Object.getPrototypeOf()`
instead of.

PR-URL: https://github.com/nodejs/node/pull/5140
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

diff --git a/.eslintrc b/.eslintrc
index a03bb13ecaf7730cac2a6594afc1138318773c57..6fc8883b41b5c8321b750858ca44f40d05672660 100644 (file)
--- a/.eslintrc
+++ b/.eslintrc
@@ -17,6 +17,8 @@ ecmaFeatures:
 rules:
   # Possible Errors
   # list: https://github.com/eslint/eslint/tree/master/docs/rules#possible-errors
+  ## Disallow Use of __proto__
+  no-proto: 2
   ## disallow control characters in regular expressions
   no-control-regex: 2
   ## check debugger sentence

diff --git a/test/common.js b/test/common.js
index 9e47a752bdc5d107a6e4c7ca2ab90663e22ab39d..ec223a1da6b950d77d2412c5156c43eb4b4956f9 100644 (file)
--- a/test/common.js
+++ b/test/common.js
@@ -190,7 +190,7 @@ exports.hasIPv6 = Object.keys(ifaces).some(function(name) {
 
 function protoCtrChain(o) {
   var result = [];
-  for (; o; o = o.__proto__) { result.push(o.constructor); }
+  for (; o; o = Object.getPrototypeOf(o)) { result.push(o.constructor); }
   return result.join();
 }
 

diff --git a/test/parallel/test-buffer-arraybuffer.js b/test/parallel/test-buffer-arraybuffer.js
index 522d97ece196c10293ac8c1887dfa9da62e7df93..56811a950e63f03a7f22b7199573367d41fef543 100644 (file)
--- a/test/parallel/test-buffer-arraybuffer.js
+++ b/test/parallel/test-buffer-arraybuffer.js
@@ -40,8 +40,8 @@ assert.equal(dv.getFloat64(8, true), 3.1415);
 
 assert.throws(function() {
   function AB() { }
-  AB.__proto__ = ArrayBuffer;
-  AB.prototype.__proto__ = ArrayBuffer.prototype;
+  Object.setPrototypeOf(AB, ArrayBuffer);
+  Object.setPrototypeOf(AB.prototype, ArrayBuffer.prototype);
   new Buffer(new AB());
 }, TypeError);
 

diff --git a/test/parallel/test-buffer-fakes.js b/test/parallel/test-buffer-fakes.js
index 1a1d9c0c494b84e91d1095a29be4d9cdcf14d5d9..ca268fa265fb0bcd7dfc93abe181585607842f1d 100644 (file)
--- a/test/parallel/test-buffer-fakes.js
+++ b/test/parallel/test-buffer-fakes.js
@@ -5,8 +5,8 @@ const assert = require('assert');
 const Buffer = require('buffer').Buffer;
 
 function FakeBuffer() { }
-FakeBuffer.__proto__ = Buffer;
-FakeBuffer.prototype.__proto__ = Buffer.prototype;
+Object.setPrototypeOf(FakeBuffer, Buffer);
+Object.setPrototypeOf(FakeBuffer.prototype, Buffer.prototype);
 
 const fb = new FakeBuffer();
 

diff --git a/test/parallel/test-buffer-inheritance.js b/test/parallel/test-buffer-inheritance.js
index ea61e50bf5f04a956d2b7b8cde31791c66c22312..be845c66ccf508aaac76493c5e54fcd0764d8b64 100644 (file)
--- a/test/parallel/test-buffer-inheritance.js
+++ b/test/parallel/test-buffer-inheritance.js
@@ -24,8 +24,9 @@ const vals = [new T(4), T(4)];
 
 vals.forEach(function(t) {
   assert.equal(t.constructor, T);
-  assert.equal(t.__proto__, T.prototype);
-  assert.equal(t.__proto__.__proto__, Buffer.prototype);
+  assert.equal(Object.getPrototypeOf(t), T.prototype);
+  assert.equal(Object.getPrototypeOf(Object.getPrototypeOf(t)),
+    Buffer.prototype);
 
   t.fill(5);
   let cntr = 0;

diff --git a/test/parallel/test-child-process-env.js b/test/parallel/test-child-process-env.js
index 89880af1cc5c0d70a0f58f9b39d78844bf1c3525..2ebc653e9a067d7b8d07d5632c923fbbd36eff1e 100644 (file)
--- a/test/parallel/test-child-process-env.js
+++ b/test/parallel/test-child-process-env.js
@@ -7,9 +7,9 @@ var spawn = require('child_process').spawn;
 var env = {
   'HELLO': 'WORLD'
 };
-env.__proto__ = {
+Object.setPrototypeOf(env, {
   'FOO': 'BAR'
-};
+});
 
 var child;
 if (common.isWindows) {