agent: ignore gathering failures on auto-generated IPs

Candidate gathering is stopped when discovery_add_local_host_candidate()
returns HOST_CANDIDATE_CANT_CREATE_SOCKET. This may be too radical
a measure when other local addresses can still be able to generate
usable candidates.

The issue was observed by a user who had an IPv6 address with tentative
flag on one of the interfaces. That single failing address was causing
the whole gathering process to end with no candidates found.

Still, don't do this if nice_agent_add_local_address() has been called.
In that case, the user really cares about the addresses and if there's
any problem, the process should fail.

https://phabricator.freedesktop.org/D1016

diff --git a/agent/agent.c b/agent/agent.c
index 189f3a2..fb4a7b1 100644 (file)
--- a/agent/agent.c
+++ b/agent/agent.c
@@ -2786,6 +2786,10 @@ nice_agent_gather_candidates (
                 " s%d:%d. Invalid interface?", agent, ip, stream->id,
                 component->id);
           }
+          if (agent->local_addresses == NULL) {
+            /* Ignore when an auto-generated address fails. */
+            continue;
+          }
           ret = FALSE;
           goto error;
         }