constify maint.c

This does a bit of constification in maint.c, making
print_bfd_section_info a bit cleaner in the process.

2014-07-24  Tom Tromey  <tromey@redhat.com>

	* maint.c (match_bfd_flags): Make "string" const.
	(print_bfd_section_info): Remove casts.
	(print_objfile_section_info): Make "string" const.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3f8d055..aaa3307 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2014-07-24  Tom Tromey  <tromey@redhat.com>
 
+       * maint.c (match_bfd_flags): Make "string" const.
+       (print_bfd_section_info): Remove casts.
+       (print_objfile_section_info): Make "string" const.
+
+2014-07-24  Tom Tromey  <tromey@redhat.com>
+
        * inf-child.c (inf_child_open_target): Make "arg" const.
        * inf-child.h (inf_child_open_target): Update.
 

diff --git a/gdb/maint.c b/gdb/maint.c
index c7a937c..99c7f9e 100644 (file)
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -236,7 +236,7 @@ match_substring (const char *string, const char *substr)
 }
 
 static int 
-match_bfd_flags (char *string, flagword flags)
+match_bfd_flags (const char *string, flagword flags)
 {
   if (flags & SEC_ALLOC)
     if (match_substring (string, "ALLOC"))
@@ -324,14 +324,15 @@ maint_print_section_info (const char *name, flagword flags,
 static void
 print_bfd_section_info (bfd *abfd, 
                        asection *asect, 
-                       void *arg)
+                       void *datum)
 {
   flagword flags = bfd_get_section_flags (abfd, asect);
   const char *name = bfd_section_name (abfd, asect);
+  const char *arg = datum;
 
-  if (arg == NULL || *((char *) arg) == '\0'
-      || match_substring ((char *) arg, name)
-      || match_bfd_flags ((char *) arg, flags))
+  if (arg == NULL || *arg == '\0'
+      || match_substring (arg, name)
+      || match_bfd_flags (arg, flags))
     {
       struct gdbarch *gdbarch = gdbarch_from_bfd (abfd);
       int addr_size = gdbarch_addr_bit (gdbarch) / 8;
@@ -348,7 +349,7 @@ print_bfd_section_info (bfd *abfd,
 static void
 print_objfile_section_info (bfd *abfd, 
                            struct obj_section *asect, 
-                           char *string)
+                           const char *string)
 {
   flagword flags = bfd_get_section_flags (abfd, asect->the_bfd_section);
   const char *name = bfd_section_name (abfd, asect->the_bfd_section);