media: rcar-csi2: Add checking to rcsi2_start_receiver()
authorNadezda Lutovinova <lutovinova@ispras.ru>
Wed, 11 Aug 2021 17:18:16 +0000 (19:18 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 5 Oct 2021 07:34:37 +0000 (09:34 +0200)
If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs
in the next cycle. That should not be possible now but adding checking
protects from future bugs.
The patch adds checking if format is NULL.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/rcar-vin/rcar-csi2.c

index a495271..d7f560e 100644 (file)
@@ -651,6 +651,8 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
 
        /* Code is validated in set_fmt. */
        format = rcsi2_code_to_fmt(priv->mf.code);
+       if (!format)
+               return -EINVAL;
 
        /*
         * Enable all supported CSI-2 channels with virtual channel and