Edje: Fix Evas 3D eet data descriptors
authorJean-Philippe Andre <jp.andre@samsung.com>
Wed, 18 Nov 2015 02:17:27 +0000 (11:17 +0900)
committerJean-Philippe Andre <jp.andre@samsung.com>
Wed, 18 Nov 2015 03:08:03 +0000 (12:08 +0900)
Memleak found with valgrind points to this line, where clearly the
edd field name is incorrect. It looks like this feature has no example,
no test case either.

This breaks EDJ ABI!
I do this because I believe there are zero users of this API
at this point, as Evas 3D is still not ready yet.

See also https://phab.enlightenment.org/D2544

@fix

src/lib/edje/edje_data.c

index f499181..218a416 100644 (file)
@@ -853,9 +853,9 @@ _edje_edd_init(void)
 
 #define EET_DATA_DESCRIPTOR_ADD_SUB_NESTED_LOOK(Edd, Type, Dec)                                                     \
   {                                                                                                                 \
-     EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, "Dec##.orientation.look1", Dec.orientation.data, EDJE_T_FLOAT); \
-     EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, "Dec##.orientation.look2", Dec.orientation.data, EDJE_T_FLOAT); \
-     EET_DATA_DESCRIPTOR_ADD_BASIC(Edd, Type, "Dec##.orientation.look_to", Dec.orientation.look_to, EET_T_INT);     \
+     EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, #Dec ".orientation.look1", Dec.orientation.data, EDJE_T_FLOAT); \
+     EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, #Dec ".orientation.look2", Dec.orientation.data, EDJE_T_FLOAT); \
+     EET_DATA_DESCRIPTOR_ADD_BASIC(Edd, Type, #Dec ".orientation.look_to", Dec.orientation.look_to, EET_T_INT);     \
   }
 
    EET_EINA_FILE_DATA_DESCRIPTOR_CLASS_SET(&eddc, Edje_Part_Description_Common);