Add additional unit tests for ResourceAttributes

Change-Id: I862f64c4cc1a5d2cc7c40f0ae30a3be1d29e2341
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1319
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

diff --git a/service/basis/common/primitiveResource/unittests/ResourceAttributesTest.cpp b/service/basis/common/primitiveResource/unittests/ResourceAttributesTest.cpp
index 21b11cb..cb66ae1 100644 (file)
--- a/service/basis/common/primitiveResource/unittests/ResourceAttributesTest.cpp
+++ b/service/basis/common/primitiveResource/unittests/ResourceAttributesTest.cpp
@@ -20,13 +20,14 @@
 
 #include <ResourceAttributes.h>
 #include <internal/ResourceAtrributesConverter.h>
+#include <internal/ResourceAttributesUtils.h>
 
 #include <gtest/gtest.h>
 
 using namespace testing;
 using namespace OIC::Service;
 
-#define KEY "key"
+constexpr char KEY[]{ "key" };
 
 class ResourceAttributesTest: public Test
 {
@@ -128,7 +129,19 @@ TEST_F(ResourceAttributesTest, CanHaveNestedResourceAttributes)
     ASSERT_TRUE("nested_value" == resourceAttributes[KEY].get<ResourceAttributes>()["nested"]);
 }
 
+TEST_F(ResourceAttributesTest, ToStringReturnsStringForValue)
+{
+    resourceAttributes[KEY] = true;
+
+    ASSERT_EQ("true", resourceAttributes[KEY].toString());
+}
+
+TEST_F(ResourceAttributesTest, ToStringReturnsEmptyStringForNullValue)
+{
+    resourceAttributes[KEY] = nullptr;
 
+    ASSERT_EQ("", resourceAttributes[KEY].toString());
+}
 
 
 class ResourceAttributesIteratorTest: public Test
@@ -200,15 +213,14 @@ TEST_F(ResourceAttributesIteratorTest, IteratorCanBeConvertedIntoConstIterator)
     ASSERT_TRUE(it == resourceAttributes.cend());
 }
 
-TEST_F(ResourceAttributesIteratorTest, ConstIteratesCam)
+TEST_F(ResourceAttributesIteratorTest, ConstIteratorIsUsedForConst)
 {
     resourceAttributes[KEY] = 1;
+    const ResourceAttributes& constAttrs = resourceAttributes;
 
-    for (const auto& i : resourceAttributes) {
-        i.key();
-    }
+    auto iter = constAttrs.begin();
 
-    ASSERT_EQ(1, resourceAttributes[KEY]);
+    ASSERT_TRUE((std::is_same<decltype(iter), ResourceAttributes::const_iterator>::value));
 }
 
 
@@ -220,6 +232,14 @@ TEST(ResourceAttributesValueTest, MovedValueHasNull)
     ASSERT_EQ(nullptr, one);
 }
 
+TEST(ResourceAttributesValueTest, SameValueIsEqual)
+{
+    ResourceAttributes::Value one { 1 };
+    ResourceAttributes::Value another { 1 };
+
+    ASSERT_EQ(one, another);
+}
+
 
 
 
@@ -292,3 +312,73 @@ TEST(ResourceAttributesConverterTest, OCRepresentationHasNullWhenResourceAttribu
 
     ASSERT_TRUE(ocRep.isNULL(KEY));
 }
+
+
+
+class ResourceAttributesUtilTest: public Test
+{
+public:
+    ResourceAttributes resourceAttributes;
+
+protected:
+    void SetUp() override
+    {
+        resourceAttributes[KEY] = 1;
+    }
+};
+
+TEST_F(ResourceAttributesUtilTest, EmptyAttributesIsAcceptable)
+{
+    ASSERT_TRUE(acceptableAttributes(resourceAttributes, ResourceAttributes()));
+}
+
+TEST_F(ResourceAttributesUtilTest, AttributesItselfIsAcceptable)
+{
+    ASSERT_TRUE(acceptableAttributes(resourceAttributes, resourceAttributes));
+}
+
+TEST_F(ResourceAttributesUtilTest, UnknownKeyIsNotAcceptable)
+{
+    ResourceAttributes newAttrs;
+    newAttrs["unknown"] = 1;
+
+    ASSERT_FALSE(acceptableAttributes(resourceAttributes, newAttrs));
+}
+
+TEST_F(ResourceAttributesUtilTest, DifferentTypeWithOriginalIsNotAcceptable)
+{
+    ResourceAttributes newAttrs;
+    newAttrs[KEY] = "";
+
+    ASSERT_FALSE(acceptableAttributes(resourceAttributes, newAttrs));
+}
+
+
+TEST_F(ResourceAttributesUtilTest, DifferentTypeOfNestedAttributeIsNotAcceptable)
+{
+    constexpr char KEY_NESTED_ATTR[]{ "nested" };
+    constexpr char KEY_NESTED_VALUE[]{ "nested_value" };
+
+    ResourceAttributes nested;
+    nested[KEY_NESTED_VALUE] = -99;
+    resourceAttributes[KEY_NESTED_ATTR] = nested;
+
+
+    ResourceAttributes newAttrs;
+    nested[KEY_NESTED_VALUE] = "abc";
+    newAttrs[KEY_NESTED_ATTR] = nested;
+
+    ASSERT_FALSE(acceptableAttributes(resourceAttributes, newAttrs));
+}
+
+TEST_F(ResourceAttributesUtilTest, ReplaceWillOverwriteOriginal)
+{
+    constexpr char NEW_VALUE[]{ "newValue" };
+
+    ResourceAttributes newAttrs;
+    newAttrs[KEY] = NEW_VALUE;
+
+    replaceAttributesRecursively(resourceAttributes, newAttrs);
+
+    ASSERT_EQ(NEW_VALUE, resourceAttributes[KEY]);
+}