MulticastOption.Group no longer accepts null. (#32518)

* MulticastOption.Group no longer accepts null.

MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation.

I also fixed two small double-cast problems while I was in here.

Fix #32490

diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/IPPacketInformation.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/IPPacketInformation.cs
index 89d1081228978bc68c318621dfac2cf501826b5b..e4df5776b93e1bbf894cf603bbf45f5df0974626 100644 (file)
--- a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/IPPacketInformation.cs
+++ b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/IPPacketInformation.cs
@@ -42,10 +42,8 @@ namespace System.Net.Sockets
             return !(packetInformation1 == packetInformation2);
         }
 
-        public override bool Equals(object comparand)
-        {
-            return comparand is IPPacketInformation && this == (IPPacketInformation)comparand;
-        }
+        public override bool Equals(object comparand) =>
+            comparand is IPPacketInformation other && this == other;
 
         public override int GetHashCode()
         {

diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
index 161c41249d286ee0e756ee0f34f311f8409db9f0..5f413cf06cfc0bc220d0d441151f69043331e68a 100644 (file)
--- a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
+++ b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
@@ -67,7 +67,7 @@ namespace System.Net.Sockets
             }
             set
             {
-                _group = value;
+                _group = value ?? throw new ArgumentNullException(nameof(value));
             }
         }
 
@@ -150,12 +150,7 @@ namespace System.Net.Sockets
             }
             set
             {
-                if (value == null)
-                {
-                    throw new ArgumentNullException(nameof(value));
-                }
-
-                _group = value;
+                _group = value ?? throw new ArgumentNullException(nameof(value));
             }
         }
 

diff --git a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
index 2e94a735933e0891b96d705901f29f1a0d0ad332..02da108c787ef789c3712acf377c1faab3540cc3 100644 (file)
--- a/src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
+++ b/src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
@@ -69,15 +69,8 @@ namespace System.Net.Sockets
         /// </summary>
         /// <param name="obj">The object to compare with this instance</param>
         /// <returns>true if obj is an instance of <see cref="UdpReceiveResult"/> and equals the value of the instance; otherwise, false</returns>
-        public override bool Equals(object obj)
-        {
-            if (!(obj is UdpReceiveResult))
-            {
-                return false;
-            }
-
-            return Equals((UdpReceiveResult)obj);
-        }
+        public override bool Equals(object obj) =>
+            obj is UdpReceiveResult other && Equals(other);
 
         /// <summary>
         /// Returns a value that indicates whether this instance is equal to a specified object

diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
index 6b712b21026ae3286a0d6b2f6e7a9fd188641f1c..456a2268e6c4795f2d797f90c25e4bf8b74965c4 100644 (file)
--- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
+++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
@@ -26,8 +26,7 @@ namespace System.Net.Sockets.Tests
             var option = new MulticastOption(IPAddress.Any);
             Assert.Same(IPAddress.Any, option.Group);
 
-            option.Group = null;
-            Assert.Null(option.Group);
+            AssertExtensions.Throws<ArgumentNullException>("value", () => option.Group = null);
 
             option.Group = IPAddress.Broadcast;
             Assert.Same(IPAddress.Broadcast, option.Group);