drm/i915/gt: Drop read from GEN8_L3CNTLREG in ICL workaround
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 30 Jun 2023 20:35:06 +0000 (13:35 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 3 Jul 2023 18:30:20 +0000 (11:30 -0700)
Now that non-masked registers are already read before programming the
context reads, the additional read became redudant, so remove it.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230630203509.1635216-5-lucas.demarchi@intel.com
drivers/gpu/drm/i915/gt/intel_workarounds.c

index 0a9c3be..b07f84c 100644 (file)
@@ -637,10 +637,7 @@ static void icl_ctx_workarounds_init(struct intel_engine_cs *engine,
                                     struct i915_wa_list *wal)
 {
        /* Wa_1406697149 (WaDisableBankHangMode:icl) */
-       wa_write(wal,
-                GEN8_L3CNTLREG,
-                intel_uncore_read(engine->uncore, GEN8_L3CNTLREG) |
-                GEN8_ERRDETBCTRL);
+       wa_write(wal, GEN8_L3CNTLREG, GEN8_ERRDETBCTRL);
 
        /* WaForceEnableNonCoherent:icl
         * This is not the same workaround as in early Gen9 platforms, where