block: return -EBUSY when there are open partitions in blkdev_reread_part
authorChristoph Hellwig <hch@lst.de>
Wed, 21 Apr 2021 16:05:02 +0000 (18:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Apr 2021 11:39:59 +0000 (13:39 +0200)
[ Upstream commit 68e6582e8f2dc32fd2458b9926564faa1fb4560e ]

The switch to go through blkdev_get_by_dev means we now ignore the
return value from bdev_disk_changed in __blkdev_get.  Add a manual
check to restore the old semantics.

Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
Reported-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210421160502.447418-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/ioctl.c

index 3be4d0e2a96c32ce23d0aba39f6a446c2437d9d6..ed240e170e148b0aa3009ad77a8d179328f54f3b 100644 (file)
@@ -98,6 +98,8 @@ static int blkdev_reread_part(struct block_device *bdev, fmode_t mode)
                return -EINVAL;
        if (!capable(CAP_SYS_ADMIN))
                return -EACCES;
+       if (bdev->bd_part_count)
+               return -EBUSY;
 
        /*
         * Reopen the device to revalidate the driver state and force a