Revert "serial: mxc: have putc use the TXFIFO"
authorFabio Estevam <festevam@denx.de>
Tue, 8 Nov 2022 11:39:33 +0000 (08:39 -0300)
committerStefano Babic <sbabic@denx.de>
Sat, 12 Nov 2022 13:16:26 +0000 (14:16 +0100)
This reverts commit c7878a0483c59c48a730123bc0f4659fd40921bf.

Since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"),
serial console corruption can be seen when priting inside board_init().

Revert it to avoid the regression.

Reported-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Tim Harvey <tharvey@gateworks.com>
drivers/serial/serial_mxc.c

index 4cf79c1..82c0d84 100644 (file)
@@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch)
        struct mxc_serial_plat *plat = dev_get_plat(dev);
        struct mxc_uart *const uart = plat->reg;
 
-       if (readl(&uart->ts) & UTS_TXFULL)
+       if (!(readl(&uart->ts) & UTS_TXEMPTY))
                return -EAGAIN;
 
        writel(ch, &uart->txd);