projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
181e5bf
)
drm/v3d: fix a NULL vs error pointer mixup
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 21 Mar 2019 06:27:31 +0000
(09:27 +0300)
committer
Eric Anholt
<eric@anholt.net>
Mon, 1 Apr 2019 16:33:38 +0000
(09:33 -0700)
The drm_gem_shmem_create() returns error pointers and v3d_bo_create() is
also supposed to return error pointers.
Fixes:
40609d4820b2
("drm/v3d: Use the new shmem helpers to reduce driver boilerplate.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link:
https://patchwork.freedesktop.org/patch/msgid/20190321062731.GC21489@kadam
drivers/gpu/drm/v3d/v3d_bo.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/v3d/v3d_bo.c
b/drivers/gpu/drm/v3d/v3d_bo.c
index
c0219eb
..
a22b75a
100644
(file)
--- a/
drivers/gpu/drm/v3d/v3d_bo.c
+++ b/
drivers/gpu/drm/v3d/v3d_bo.c
@@
-130,8
+130,8
@@
struct v3d_bo *v3d_bo_create(struct drm_device *dev, struct drm_file *file_priv,
int ret;
shmem_obj = drm_gem_shmem_create(dev, unaligned_size);
- if (
!shmem_obj
)
- return
NULL
;
+ if (
IS_ERR(shmem_obj)
)
+ return
ERR_CAST(shmem_obj)
;
bo = to_v3d_bo(&shmem_obj->base);
ret = v3d_bo_create_finish(&shmem_obj->base);