gstplay: avoid getting property of playbin2 if subtitle_sid is null

 There is a probability of getting "current-text" property
 when play with playbin3, and this property is available
 only in playbin2.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4661>

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
index f99bbe1bcd3b3ed77db3e36e3408556f771454af..c88d8e94c27648d6f2c8c121ee162b4394189447 100644 (file)
--- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
@@ -1762,9 +1762,11 @@ gst_play_subtitle_info_update (GstPlay * self, GstPlayStreamInfo * stream_info)
 
       g_object_get (G_OBJECT (self->playbin), "current-suburi", &suburi, NULL);
       if (suburi) {
-        if (self->use_playbin3 && self->subtitle_sid) {
-          if (g_str_equal (self->subtitle_sid, stream_info->stream_id))
+        if (self->use_playbin3) {
+          if (self->subtitle_sid &&
+              g_str_equal (self->subtitle_sid, stream_info->stream_id)) {
             info->language = g_path_get_basename (suburi);
+          }
         } else {
           g_object_get (G_OBJECT (self->playbin), "current-text", &text_index,
               NULL);