drm/amdgpu: refine sdma4 ras_data_cb
authorTao Zhou <tao.zhou1@amd.com>
Tue, 17 Sep 2019 11:01:38 +0000 (19:01 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 3 Oct 2019 14:11:02 +0000 (09:11 -0500)
simplify code logic and refine return value

v2: remove unused error source code

Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

index 68a9dfe..4db4e32 100644 (file)
@@ -1942,28 +1942,18 @@ static int sdma_v4_0_process_ras_data_cb(struct amdgpu_device *adev,
                void *err_data,
                struct amdgpu_iv_entry *entry)
 {
-       uint32_t err_source;
        int instance;
 
-       if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX)) {
-               instance = sdma_v4_0_irq_id_to_seq(entry->client_id);
-               if (instance < 0)
-                       return 0;
+       if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
+               goto out;
 
-               switch (entry->src_id) {
-               case SDMA0_4_0__SRCID__SDMA_SRAM_ECC:
-                       err_source = 0;
-                       break;
-               case SDMA0_4_0__SRCID__SDMA_ECC:
-                       err_source = 1;
-                       break;
-               default:
-                       return 0;
-               }
+       instance = sdma_v4_0_irq_id_to_seq(entry->client_id);
+       if (instance < 0)
+               goto out;
 
-               amdgpu_sdma_process_ras_data_cb(adev, err_data, entry);
-       }
+       amdgpu_sdma_process_ras_data_cb(adev, err_data, entry);
 
+out:
        return AMDGPU_RAS_SUCCESS;
 }