* hurd/get-host.c (_hurd_get_host_config): Fix possible buffer underrun and make...

2000-11-13  Marcus Brinkmann <marcus@gnu.org>

	* hurd/get-host.c (_hurd_get_host_config): Fix possible buffer
	underrun and make sure the result is null terminated even if there
	is no trailing newline.

diff --git a/ChangeLog b/ChangeLog
index e2b9ef9cf7aabe32e879697325419231411efc8f..2f6df1dc3632c6d167059c11926846a8cbb82024 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2000-11-13  Marcus Brinkmann <marcus@gnu.org>
+
+       * hurd/get-host.c (_hurd_get_host_config): Fix possible buffer
+       underrun and make sure the result is null terminated even if there
+       is no trailing newline.
+
 2000-11-13  Jakub Jelinek  <jakub@redhat.com>
 
        * sysdeps/alpha/fpu/libm-test-ulps: Update.

diff --git a/hurd/get-host.c b/hurd/get-host.c
index 7c55afa0aee84c99aec32968ead24d9e5ed57b32..93890c724eca3485faa62ad8ec356cca5e768616 100644 (file)
--- a/hurd/get-host.c
+++ b/hurd/get-host.c
@@ -1,5 +1,5 @@
 /* Get a host configuration item kept as the whole contents of a file.
-   Copyright (C) 1996, 1997, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1996, 1997, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -70,11 +70,18 @@ _hurd_get_host_config (const char *item, char *buf, size_t buflen)
        *buf = '\0';
       return 0;
     }
-    
+
   /* Remove newlines in case someone wrote the file by hand.  */
-  while (buf[nread - 1] == '\n')
+  while (buf[nread - 1] == '\n' && nread > 0)
     buf[--nread] = '\0';
 
+  /* Null-terminate the result if there is enough space.  */
+  if (nread < buflen)
+    buf[nread] = '\0';
+  else
+    if (buf[nread - 1] != '\0')
+      more = 1;
+
   if (more)
     /* If we didn't read the whole file, tell the caller to use a bigger
        buffer next time.  */