dmaengine: moxart-dma: Fix memory leak when stopping a running transfer
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 27 Mar 2015 11:35:55 +0000 (13:35 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 30 Mar 2015 17:47:08 +0000 (23:17 +0530)
The vd->node is removed from the lists when the transfer started so the
vchan_get_all_descriptors() will not find it. This results memory leak.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/moxart-dma.c

index 15cab7d..b463410 100644 (file)
@@ -193,8 +193,10 @@ static int moxart_terminate_all(struct dma_chan *chan)
 
        spin_lock_irqsave(&ch->vc.lock, flags);
 
-       if (ch->desc)
+       if (ch->desc) {
+               moxart_dma_desc_free(&ch->desc->vd);
                ch->desc = NULL;
+       }
 
        ctrl = readl(ch->base + REG_OFF_CTRL);
        ctrl &= ~(APB_DMA_ENABLE | APB_DMA_FIN_INT_EN | APB_DMA_ERR_INT_EN);