wifi: mwifiex: fix endian annotations in casts
authorJohannes Berg <johannes.berg@intel.com>
Sun, 4 Sep 2022 19:29:09 +0000 (21:29 +0200)
committerKalle Valo <kvalo@kernel.org>
Wed, 7 Sep 2022 08:02:59 +0000 (11:02 +0300)
These cause sparse warnings, and since the device generally
works in little endian we can assume the code is correct, so
just fix the casts accordingly. No binary changes on x86.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220904212910.3f72609a3825.If4048592701bf04981be1dab18eaaa339b2ea382@changeid
drivers/net/wireless/marvell/mwifiex/usb.c

index c2f2ce2..d3ab957 100644 (file)
@@ -911,14 +911,14 @@ static int mwifiex_usb_prepare_tx_aggr_skb(struct mwifiex_adapter *adapter,
                memcpy(payload, skb_tmp->data, skb_tmp->len);
                if (skb_queue_empty(&port->tx_aggr.aggr_list)) {
                        /* do not padding for last packet*/
-                       *(u16 *)payload = cpu_to_le16(skb_tmp->len);
-                       *(u16 *)&payload[2] =
+                       *(__le16 *)payload = cpu_to_le16(skb_tmp->len);
+                       *(__le16 *)&payload[2] =
                                cpu_to_le16(MWIFIEX_TYPE_AGGR_DATA_V2 | 0x80);
                        skb_trim(skb_aggr, skb_aggr->len - pad);
                } else {
                        /* add aggregation interface header */
-                       *(u16 *)payload = cpu_to_le16(skb_tmp->len + pad);
-                       *(u16 *)&payload[2] =
+                       *(__le16 *)payload = cpu_to_le16(skb_tmp->len + pad);
+                       *(__le16 *)&payload[2] =
                                cpu_to_le16(MWIFIEX_TYPE_AGGR_DATA_V2);
                }
 
@@ -1097,9 +1097,9 @@ send_aggr_buf:
                }
 
                payload = skb->data;
-               *(u16 *)&payload[2] =
+               *(__le16 *)&payload[2] =
                        cpu_to_le16(MWIFIEX_TYPE_AGGR_DATA_V2 | 0x80);
-               *(u16 *)payload = cpu_to_le16(skb->len);
+               *(__le16 *)payload = cpu_to_le16(skb->len);
                skb_send = skb;
                context = &port->tx_data_list[port->tx_data_ix++];
                return mwifiex_usb_construct_send_urb(adapter, port, ep,