usb: renesas: Fix refcount leak bug
authorLiang He <windhl@126.com>
Sat, 18 Jun 2022 02:32:05 +0000 (10:32 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:40:33 +0000 (11:40 +0200)
[ Upstream commit 9d6d5303c39b8bc182475b22f45504106a07f086 ]

In usbhs_rza1_hardware_init(), of_find_node_by_name() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220618023205.4056548-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/renesas_usbhs/rza.c

index 24de64e..2d77ede 100644 (file)
@@ -23,6 +23,10 @@ static int usbhs_rza1_hardware_init(struct platform_device *pdev)
        extal_clk = of_find_node_by_name(NULL, "extal");
        of_property_read_u32(usb_x1_clk, "clock-frequency", &freq_usb);
        of_property_read_u32(extal_clk, "clock-frequency", &freq_extal);
+
+       of_node_put(usb_x1_clk);
+       of_node_put(extal_clk);
+
        if (freq_usb == 0) {
                if (freq_extal == 12000000) {
                        /* Select 12MHz XTAL */