Powerpc 8xx CPM_UART maxidl should not depend on fifo size
authorChristophe Leroy <christophe.leroy@c-s.fr>
Mon, 24 Sep 2012 06:20:18 +0000 (08:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2012 20:39:39 +0000 (13:39 -0700)
maxidl register was set to fifo size. There is no reason to set this
register to same value as fifo size. Setting it now to 0x10 by default
as in the UCC UART driver.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/cpm_uart/cpm_uart_core.c

index 46edc64..7f6a1c7 100644 (file)
@@ -799,7 +799,7 @@ static void cpm_uart_init_scc(struct uart_cpm_port *pinfo)
        cpm_set_scc_fcr(sup);
 
        out_be16(&sup->scc_genscc.scc_mrblr, pinfo->rx_fifosize);
-       out_be16(&sup->scc_maxidl, pinfo->rx_fifosize);
+       out_be16(&sup->scc_maxidl, 0x10);
        out_be16(&sup->scc_brkcr, 1);
        out_be16(&sup->scc_parec, 0);
        out_be16(&sup->scc_frmec, 0);
@@ -873,7 +873,7 @@ static void cpm_uart_init_smc(struct uart_cpm_port *pinfo)
 
        /* Using idle character time requires some additional tuning.  */
        out_be16(&up->smc_mrblr, pinfo->rx_fifosize);
-       out_be16(&up->smc_maxidl, pinfo->rx_fifosize);
+       out_be16(&up->smc_maxidl, 0x10);
        out_be16(&up->smc_brklen, 0);
        out_be16(&up->smc_brkec, 0);
        out_be16(&up->smc_brkcr, 1);