crypto: asymmetric_keys - set error code on failure
authorPan Bian <bianpan2016@163.com>
Tue, 13 Dec 2016 09:26:18 +0000 (09:26 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 14 Dec 2016 10:33:13 +0000 (18:33 +0800)
In function public_key_verify_signature(), returns variable ret on
error paths. When the call to kmalloc() fails, the value of ret is 0,
and it is not set to an errno before returning. This patch fixes the
bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/asymmetric_keys/public_key.c

index fd76b5f..d3a989e 100644 (file)
@@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
        if (ret)
                goto error_free_req;
 
+       ret = -ENOMEM;
        outlen = crypto_akcipher_maxsize(tfm);
        output = kmalloc(outlen, GFP_KERNEL);
        if (!output)