drm/tegra: firewall: Check for is_addr_reg existence in IMM check
authorMikko Perttunen <mperttunen@nvidia.com>
Thu, 19 Jan 2023 13:39:01 +0000 (15:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:16 +0000 (09:33 +0100)
[ Upstream commit 1b5c09de25e8c08655c270a70e5e74e93b6bad1f ]

In the IMM opcode check, don't call is_addr_reg if it's not set.

Fixes: 8cc95f3fd35e ("drm/tegra: Add job firewall")
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/tegra/firewall.c

index 1824d2d..d53f890 100644 (file)
@@ -97,6 +97,9 @@ static int fw_check_regs_imm(struct tegra_drm_firewall *fw, u32 offset)
 {
        bool is_addr;
 
+       if (!fw->client->ops->is_addr_reg)
+               return 0;
+
        is_addr = fw->client->ops->is_addr_reg(fw->client->base.dev, fw->class,
                                               offset);
        if (is_addr)