qtnfmac: remove meaningless goto statement and labels
authorwengjianfeng <wengjianfeng@yulong.com>
Tue, 6 Apr 2021 02:52:06 +0000 (10:52 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 17 Apr 2021 17:33:27 +0000 (20:33 +0300)
some function's label meaningless, the label statement follows
the goto statement, no other statements, so just remove it.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210406025206.4924-1-samirweng1979@163.com
drivers/net/wireless/quantenna/qtnfmac/commands.c

index f3ccbd2..c68563c 100644 (file)
@@ -379,10 +379,6 @@ int qtnf_cmd_send_stop_ap(struct qtnf_vif *vif)
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -407,10 +403,7 @@ int qtnf_cmd_send_register_mgmt(struct qtnf_vif *vif, u16 frame_type, bool reg)
        cmd->do_register = reg;
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -446,10 +439,7 @@ int qtnf_cmd_send_frame(struct qtnf_vif *vif, u32 cookie, u16 flags,
                qtnf_cmd_skb_put_buffer(cmd_skb, buf, len);
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -477,10 +467,6 @@ int qtnf_cmd_send_mgmt_set_appie(struct qtnf_vif *vif, u8 frame_type,
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -1677,10 +1663,7 @@ int qtnf_cmd_send_update_phy_params(struct qtnf_wmac *mac, u32 changed)
                                         wiphy->retry_short);
 
        ret = qtnf_cmd_send(mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(mac->bus);
 
        return ret;
@@ -1772,10 +1755,7 @@ int qtnf_cmd_send_add_key(struct qtnf_vif *vif, u8 key_index, bool pairwise,
                                         params->seq_len);
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -1807,10 +1787,7 @@ int qtnf_cmd_send_del_key(struct qtnf_vif *vif, u8 key_index, bool pairwise,
        cmd->pairwise = pairwise;
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -1837,10 +1814,7 @@ int qtnf_cmd_send_set_default_key(struct qtnf_vif *vif, u8 key_index,
        cmd->multicast = multicast;
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -1864,10 +1838,7 @@ int qtnf_cmd_send_set_default_mgmt_key(struct qtnf_vif *vif, u8 key_index)
        cmd->key_index = key_index;
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -1931,8 +1902,6 @@ int qtnf_cmd_send_change_sta(struct qtnf_vif *vif, const u8 *mac,
        }
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
 out:
        qtnf_bus_unlock(vif->mac->bus);
@@ -1966,10 +1935,7 @@ int qtnf_cmd_send_del_sta(struct qtnf_vif *vif,
        cmd->reason_code = cpu_to_le16(params->reason_code);
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -2189,10 +2155,6 @@ int qtnf_cmd_send_connect(struct qtnf_vif *vif,
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -2218,10 +2180,6 @@ int qtnf_cmd_send_external_auth(struct qtnf_vif *vif,
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -2245,10 +2203,7 @@ int qtnf_cmd_send_disconnect(struct qtnf_vif *vif, u16 reason_code)
        cmd->reason = cpu_to_le16(reason_code);
 
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -2271,10 +2226,6 @@ int qtnf_cmd_send_updown_intf(struct qtnf_vif *vif, bool up)
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;
@@ -2580,10 +2531,6 @@ int qtnf_cmd_start_cac(const struct qtnf_vif *vif,
 
        qtnf_bus_lock(bus);
        ret = qtnf_cmd_send(bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(bus);
 
        return ret;
@@ -2611,10 +2558,6 @@ int qtnf_cmd_set_mac_acl(const struct qtnf_vif *vif,
 
        qtnf_bus_lock(bus);
        ret = qtnf_cmd_send(bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(bus);
 
        return ret;
@@ -2639,10 +2582,7 @@ int qtnf_cmd_send_pm_set(const struct qtnf_vif *vif, u8 pm_mode, int timeout)
        qtnf_bus_lock(bus);
 
        ret = qtnf_cmd_send(bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(bus);
 
        return ret;
@@ -2754,10 +2694,7 @@ int qtnf_cmd_send_wowlan_set(const struct qtnf_vif *vif,
        cmd->triggers = cpu_to_le32(triggers);
 
        ret = qtnf_cmd_send(bus, cmd_skb);
-       if (ret)
-               goto out;
 
-out:
        qtnf_bus_unlock(bus);
        return ret;
 }
@@ -2821,10 +2758,6 @@ int qtnf_cmd_send_update_owe(struct qtnf_vif *vif,
 
        qtnf_bus_lock(vif->mac->bus);
        ret = qtnf_cmd_send(vif->mac->bus, cmd_skb);
-       if (ret)
-               goto out;
-
-out:
        qtnf_bus_unlock(vif->mac->bus);
 
        return ret;