ixgbe: Clean up redundancy in hw_enc_features
authorMark Rustad <mark.d.rustad@intel.com>
Wed, 18 Nov 2015 23:37:04 +0000 (15:37 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 30 Dec 2015 03:16:06 +0000 (19:16 -0800)
Clean up minor redundancy in the setting of hw_enc_features that
makes it appears that X550 uniquely has more encapsulation features
than other devices. The driver only supports one more feature, so
make it look that way. No longer set NETIF_F_SG since that is set
by the register_netdev call. Thanks to Alex Duyck for noticing this
slight confusion.

Reported-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index c5c0fb4..ea9537d 100644 (file)
@@ -9015,8 +9015,7 @@ skip_sriov:
        netdev->vlan_features |= NETIF_F_IPV6_CSUM;
        netdev->vlan_features |= NETIF_F_SG;
 
-       netdev->hw_enc_features |= NETIF_F_SG | NETIF_F_IP_CSUM |
-                                  NETIF_F_IPV6_CSUM;
+       netdev->hw_enc_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
 
        netdev->priv_flags |= IFF_UNICAST_FLT;
        netdev->priv_flags |= IFF_SUPP_NOFCS;
@@ -9025,9 +9024,7 @@ skip_sriov:
        switch (adapter->hw.mac.type) {
        case ixgbe_mac_X550:
        case ixgbe_mac_X550EM_x:
-               netdev->hw_enc_features |= NETIF_F_RXCSUM |
-                                          NETIF_F_IP_CSUM |
-                                          NETIF_F_IPV6_CSUM;
+               netdev->hw_enc_features |= NETIF_F_RXCSUM;
                break;
        default:
                break;