Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of https://codereview.chrom...
authormtklein <mtklein@google.com>
Thu, 2 Apr 2015 22:41:25 +0000 (15:41 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 2 Apr 2015 22:41:25 +0000 (15:41 -0700)
Reason for revert:
whatever compiler we're using can't handle array subscripts for neon vectors

Original issue's description:
> Try ARMv7 and NEON for Daisy.
>
> I think Daisy's color order problems are in non-NEON ARM assembly.
> NEON might actually be fine.
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843

Review URL: https://codereview.chromium.org/1058173002

platform_tools/chromeos/bin/chromeos_setup.sh

index b04eb1b..de4d6f9 100755 (executable)
@@ -34,7 +34,8 @@ setup_device() {
         GENERIC_BOARD_TYPE="amd64-generic"
         ;;
     daisy)
-        DEFINES="${DEFINES} skia_arch_type=arm arm_version=7 arm_neon=1"
+        # TODO(mtklein): make this arm_version=7 arm_neon=1
+        DEFINES="${DEFINES} skia_arch_type=arm"
         # TODO(borenet): We have to define skia_warnings_as_errors=0 for the arm
         # build, which throws lots of "mangling of va_list has changed" warnings.
         DEFINES="${DEFINES} skia_warnings_as_errors=0"