btrfs-progs: fix btrfs quota rescan failed on PPC64 arch
authorGeorge Wang <xuw2015@gmail.com>
Mon, 20 Apr 2015 05:33:16 +0000 (13:33 +0800)
committerDavid Sterba <dsterba@suse.cz>
Fri, 24 Apr 2015 13:41:59 +0000 (15:41 +0200)
PPC64 arch use such following IOC values "
\#define _IOC_NONE       1U
\#define _IOC_READ       2U
\#define _IOC_WRITE      4U
" comparing to the default IOC values "
\#define _IOC_NONE       0U
\#define _IOC_READ       2U
\#define _IOC_WRITE      1U"

This means the value "_IOW*" will be negative when we store it in the int
variables. Such as the "BTRFS_IOC_QGROUP_CREATE", it will be "0x4010942e" on
X86_64, but "0x8010942e" on PPC64.
Notice that the IOC values are the "unsigned long" type, so we use the
"unsigned long" to store it, and this can insure the comparison between the
variable and BTRFS_IOC_* valid.

Signed-off-by: George Wang <xuw2015@gmail.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
[manpage states that it's int, kernel uses unsigned int, glibc wants
unsigned long int]
Tested-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
cmds-quota.c

index 89cc89c..f6a1cfa 100644 (file)
@@ -109,7 +109,7 @@ static int cmd_quota_rescan(int argc, char **argv)
        int e;
        char *path = NULL;
        struct btrfs_ioctl_quota_rescan_args args;
-       int ioctlnum = BTRFS_IOC_QUOTA_RESCAN;
+       unsigned long ioctlnum = BTRFS_IOC_QUOTA_RESCAN;
        DIR *dirstream = NULL;
        int wait_for_completion = 0;