staging: dgnc: Check sscanf return value
authorRoberta Dobrescu <roberta.dobrescu@gmail.com>
Fri, 19 Sep 2014 21:01:39 +0000 (00:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Sep 2014 00:25:23 +0000 (17:25 -0700)
This fixes the following checkpatch.pl warnings:
WARNING: unchecked sscanf return value

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgnc/dgnc_sysfs.c

index 207fa25..0d425ad 100644 (file)
@@ -70,7 +70,11 @@ static ssize_t dgnc_driver_debug_show(struct device_driver *ddp, char *buf)
 
 static ssize_t dgnc_driver_debug_store(struct device_driver *ddp, const char *buf, size_t count)
 {
-       sscanf(buf, "0x%x\n", &dgnc_debug);
+       int ret;
+
+       ret = sscanf(buf, "0x%x\n", &dgnc_debug);
+       if (ret != 1)
+               return -EINVAL;
        return count;
 }
 static DRIVER_ATTR(debug, (S_IRUSR | S_IWUSR), dgnc_driver_debug_show, dgnc_driver_debug_store);
@@ -83,7 +87,11 @@ static ssize_t dgnc_driver_rawreadok_show(struct device_driver *ddp, char *buf)
 
 static ssize_t dgnc_driver_rawreadok_store(struct device_driver *ddp, const char *buf, size_t count)
 {
-       sscanf(buf, "0x%x\n", &dgnc_rawreadok);
+       int ret;
+
+       ret = sscanf(buf, "0x%x\n", &dgnc_rawreadok);
+       if (ret != 1)
+               return -EINVAL;
        return count;
 }
 static DRIVER_ATTR(rawreadok, (S_IRUSR | S_IWUSR), dgnc_driver_rawreadok_show, dgnc_driver_rawreadok_store);
@@ -96,7 +104,11 @@ static ssize_t dgnc_driver_pollrate_show(struct device_driver *ddp, char *buf)
 
 static ssize_t dgnc_driver_pollrate_store(struct device_driver *ddp, const char *buf, size_t count)
 {
-       sscanf(buf, "%d\n", &dgnc_poll_tick);
+       int ret;
+
+       ret = sscanf(buf, "%d\n", &dgnc_poll_tick);
+       if (ret != 1)
+               return -EINVAL;
        return count;
 }
 static DRIVER_ATTR(pollrate, (S_IRUSR | S_IWUSR), dgnc_driver_pollrate_show, dgnc_driver_pollrate_store);