Fix memory leak

Change-Id: Id56f1b7c0fc6c78fe1ce83dca908f90d14571e51
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>

diff --git a/src/badge_db.c b/src/badge_db.c
index 0bbc57a..e143ae9 100644 (file)
--- a/src/badge_db.c
+++ b/src/badge_db.c
@@ -69,15 +69,14 @@ static int __check_integrity_cb(void *pid, int argc, char **argv, char **notUsed
 /* LCOV_EXCL_STOP */
 
 /* LCOV_EXCL_START */
-static int __recover_corrupted_db(sqlite3 *db)
+static int __recover_corrupted_db()
 {
        int ret = BADGE_ERROR_NONE;
        int sql_ret;
        char *errmsg = NULL;
+       sqlite3 *db = NULL;
 
        INFO("DB is corrupted, start to recover corrupted db");
-       if (db)
-               sqlite3_close(db);
        unlink(BADGE_DB_PATH);
 
        sql_ret = sqlite3_open_v2(BADGE_DB_PATH, &db,
@@ -100,6 +99,9 @@ out:
        if (errmsg)
                sqlite3_free(errmsg);
 
+       if (db)
+               sqlite3_close_v2(db);
+
        return ret;
 }
 /* LCOV_EXCL_STOP */
@@ -135,12 +137,14 @@ EXPORT_API int badge_db_init(void)
        }
 
 out:
-       if (sql_ret == SQLITE_CORRUPT || sql_ret == SQLITE_NOTADB || is_db_corrupted)
-               ret = __recover_corrupted_db(db);
        if (errmsg)
                sqlite3_free(errmsg);
        if (db)
-               db_util_close(db);
+               sqlite3_close_v2(db);
+
+       if (sql_ret == SQLITE_CORRUPT || sql_ret == SQLITE_NOTADB
+                       || is_db_corrupted)
+               ret = __recover_corrupted_db();
 
        return ret;
 }