pwm: vt8500: Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 21 Jun 2021 13:04:57 +0000 (15:04 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 30 Jun 2021 17:12:20 +0000 (19:12 +0200)
vt8500_pwm_remove() is only called after vt8500_pwm_probe() returned
successfully. In this case driver data was set to a non-NULL value
and so chip can never be NULL.

While touching this code also put declaration and assignment in a single
line.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-vt8500.c

index f9eb36be908818cd99072efd920415b29a00af6b..7164df2fbacf8677dffe3f468599312093c38f38 100644 (file)
@@ -238,11 +238,8 @@ static int vt8500_pwm_probe(struct platform_device *pdev)
 
 static int vt8500_pwm_remove(struct platform_device *pdev)
 {
-       struct vt8500_chip *chip;
+       struct vt8500_chip *chip = platform_get_drvdata(pdev);
 
-       chip = platform_get_drvdata(pdev);
-       if (chip == NULL)
-               return -ENODEV;
 
        clk_unprepare(chip->clk);