rtlwifi: use true,false for bool variable in rtl_init_rfkill()
authorJason Yan <yanaijie@huawei.com>
Sun, 26 Apr 2020 09:41:15 +0000 (17:41 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 6 May 2020 08:32:30 +0000 (11:32 +0300)
The 'blocked' is a bool variable, and '==' expression itself is bool
too. So no need to convert it to 0/1.

This fixes the following coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/base.c:508:13-41: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200426094115.23294-1-yanaijie@huawei.com
drivers/net/wireless/realtek/rtlwifi/base.c

index c75192c..a4489b9 100644 (file)
@@ -505,7 +505,7 @@ void rtl_init_rfkill(struct ieee80211_hw *hw)
 
                rtlpriv->rfkill.rfkill_state = radio_state;
 
-               blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1;
+               blocked = rtlpriv->rfkill.rfkill_state != 1;
                wiphy_rfkill_set_hw_state(hw->wiphy, blocked);
        }