platform/x86: apple-gmux: Fix iomem_base __iomem annotation
authorHans de Goede <hdegoede@redhat.com>
Tue, 4 Apr 2023 11:19:55 +0000 (13:19 +0200)
committerHans de Goede <hdegoede@redhat.com>
Thu, 6 Apr 2023 12:24:04 +0000 (14:24 +0200)
Fix the __iomem annotation of the iomem_base pointers in the apple-gmux
code. The __iomem should go before the *.

This fixes a bunch of sparse warnings like this one:

drivers/platform/x86/apple-gmux.c:224:48: sparse:
 expected void const [noderef] __iomem *
 got unsigned char [usertype] *

Fixes: 0c18184de990 ("platform/x86: apple-gmux: support MMIO gmux on T2 Macs")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304040401.IMxt7Ubi-lkp@intel.com/
Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
Link: https://lore.kernel.org/r/20230404111955.43266-1-hdegoede@redhat.com
drivers/platform/x86/apple-gmux.c
include/linux/apple-gmux.h

index 4c311e1..e02b4ae 100644 (file)
@@ -57,7 +57,7 @@
 struct apple_gmux_config;
 
 struct apple_gmux_data {
-       u8 *__iomem iomem_base;
+       u8 __iomem *iomem_base;
        unsigned long iostart;
        unsigned long iolen;
        const struct apple_gmux_config *config;
index a7a7d43..206d97f 100644 (file)
@@ -66,7 +66,7 @@ static inline bool apple_gmux_is_indexed(unsigned long iostart)
 
 static inline bool apple_gmux_is_mmio(unsigned long iostart)
 {
-       u8 *__iomem iomem_base = ioremap(iostart, 16);
+       u8 __iomem *iomem_base = ioremap(iostart, 16);
        u8 val;
 
        if (!iomem_base)