[ITC][url-download][Non-ACR][Usage of CHECK_HANDLE_CLEANUP macro for better readability]

Change-Id: I1502178bf13933a49423c3fe8a7cb58481d1482d
Signed-off-by: manu.tiwari <manu.tiwari@samsung.com>

diff --git a/src/itc/url-download/ITs-url-download-common.h b/src/itc/url-download/ITs-url-download-common.h
index 536faf8d523f626b071a37859253e0eae3b5e773..cfa4c0064b9aa5781e3d3d7676cdc023bf1055a6 100755 (executable)
--- a/src/itc/url-download/ITs-url-download-common.h
+++ b/src/itc/url-download/ITs-url-download-common.h
@@ -67,6 +67,14 @@ void DownloadStateCallback(int download_id, download_state_e state, void *user_d
                return 1;\
        }\
 }
+#define CHECK_HANDLE_CLEANUP(Handle, API, FreeResource) {\
+        if ( Handle == NULL )\
+        {\
+                 FPRINTF("[Line : %d][%s] %s failed, error returned = Handle returned is NULL\\n", __LINE__, API_NAMESPACE, API);\
+                 FreeResource;\
+                 return 1;\
+         }\
+}
 
 #define RUN_POLLING_LOOP {\
        g_pMainLoop = g_main_loop_new(NULL, false);\

diff --git a/src/itc/url-download/ITs-url-download-set-get.c b/src/itc/url-download/ITs-url-download-set-get.c
index af0ac582dca922aeee5273a625de1747605858dc..e7d3b44891d0a8bb53dfc4490d45e852acfae2a9 100755 (executable)
--- a/src/itc/url-download/ITs-url-download-set-get.c
+++ b/src/itc/url-download/ITs-url-download-set-get.c
@@ -149,12 +149,7 @@ int ITc_download_set_get_notification_app_control_p(void)
        // Target API
        nRet = download_get_notification_app_control(g_nDownloadRequestID, DOWNLOAD_NOTIFICATION_APP_CONTROL_TYPE_ONGOING, &pstGetAppControlHandle);
        PRINT_RESULT_CLEANUP(DOWNLOAD_ERROR_NONE, nRet, "download_get_notification_app_control", UrlDownloadGetError(nRet), app_control_destroy(pstAppControlHandle));
-       if(pstGetAppControlHandle == NULL)
-       {
-               FPRINTF("[Line : %d][%s] download_get_notification_app_control, handle returned = NULL\\n", __LINE__, API_NAMESPACE);
-               app_control_destroy(pstAppControlHandle);
-               return 1;
-       }
+       CHECK_HANDLE_CLEANUP(pstGetAppControlHandle,"download_get_notification_app_control",app_control_destroy(pstAppControlHandle));
        FREE_MEMORY(pstGetAppControlHandle);
 
        nRet = app_control_destroy(pstAppControlHandle);