fix SVACE issue, dbus method call logging & indentation 66/99166/5
authorHyunseok Lee <hs7388.lee@samsung.com>
Tue, 22 Nov 2016 05:40:08 +0000 (14:40 +0900)
committerSeungbae Shin <seungbae.shin@samsung.com>
Wed, 4 Jan 2017 07:22:06 +0000 (16:22 +0900)
[Version] 0.10.78
[Profile] Common
[Issue Type] cleaun up

Change-Id: I177ff49b0dcf3f0f0dede65afae60618160746fb

common/mm_sound_dbus.c
packaging/libmm-sound.spec

index 7cb760c..e33cc82 100644 (file)
@@ -242,7 +242,7 @@ static int _dbus_method_call(GDBusConnection* conn, const char* bus_name, const
 
        if (!dbus_reply) {
                char *err_name = NULL, *err_msg = NULL;
-               debug_log("Method Call '%s.%s' Failed, %s", intf, method, err->message);
+               debug_error("Method Call '%s.%s' Failed, %s", intf, method, err->message);
 
                if (_parse_error_msg(err->message,  &err_name, &err_msg) < 0) {
                        debug_error("failed to parse error message");
@@ -251,9 +251,10 @@ static int _dbus_method_call(GDBusConnection* conn, const char* bus_name, const
                }
                ret = _convert_error_name(err_name);
                g_error_free(err);
+       } else {
+               debug_log("Method Call '%s.%s' Success", intf, method);
        }
 
-       debug_log("Method Call '%s.%s' Success", intf, method);
        *result = dbus_reply;
 
        return ret;
@@ -405,7 +406,7 @@ int mm_sound_dbus_method_call_to(audio_provider_t provider, audio_method_t metho
                return MM_ERROR_SOUND_INTERNAL;
        }
 
-       if((ret = _dbus_method_call(conn, g_paths[provider].bus_name,
+       if ((ret = _dbus_method_call(conn, g_paths[provider].bus_name,
                                      g_paths[provider].object,
                                      g_paths[provider].interface,
                                      g_methods[method_type].name,
@@ -493,7 +494,7 @@ int mm_sound_dbus_signal_subscribe_to(audio_provider_t provider, audio_event_t e
        cb_data->user_data = userdata;
        cb_data->free_func = freefunc;
 
-       if(_dbus_subscribe_signal(conn, g_paths[provider].object, g_paths[provider].interface, g_events[event].name,
+       if (_dbus_subscribe_signal(conn, g_paths[provider].object, g_paths[provider].interface, g_events[event].name,
                                                        _dbus_signal_callback, &_subs_id, cb_data, callback_data_free_func) != MM_ERROR_NONE) {
                debug_error("Dbus Subscribe on Client Error");
                goto fail;
index a4a7ee5..1e0ddf5 100644 (file)
@@ -1,6 +1,6 @@
 Name:       libmm-sound
 Summary:    MMSound Package contains client lib and sound_server binary
-Version:    0.10.77
+Version:    0.10.78
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0