serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 1 Sep 2022 14:39:34 +0000 (17:39 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:11:54 +0000 (11:11 +0200)
commit 1d10cd4da593bc0196a239dcc54dac24b6b0a74e upstream.

Tx'ing does not correctly account Tx'ed characters into icount.tx.
Using uart_xmit_advance() fixes the problem.

Fixes: 2d908b38d409 ("serial: Add Tegra Combined UART driver")
Cc: <stable@vger.kernel.org> # serial: Create uart_xmit_advance()
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220901143934.8850-4-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/tegra-tcu.c

index 4877c54c613d1f0d899855350b1e9a81a1a001df..889b701ba7c6258aec81c0ad17acfc5839073272 100644 (file)
@@ -101,7 +101,7 @@ static void tegra_tcu_uart_start_tx(struct uart_port *port)
                        break;
 
                tegra_tcu_write(tcu, &xmit->buf[xmit->tail], count);
-               xmit->tail = (xmit->tail + count) & (UART_XMIT_SIZE - 1);
+               uart_xmit_advance(port, count);
        }
 
        uart_write_wakeup(port);