Bluetooth: mark expected switch fall-throughs
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Thu, 12 Oct 2017 22:24:02 +0000 (17:24 -0500)
committerMarcel Holtmann <marcel@holtmann.org>
Sat, 14 Oct 2017 07:25:51 +0000 (09:25 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

In this particular case, notice that I replaced the
"deliberate fall-through..." comment with a "fall through"
comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/bcm203x.c
drivers/bluetooth/hci_ll.c

index 5ce6d41..8e9547f 100644 (file)
@@ -121,7 +121,7 @@ static void bcm203x_complete(struct urb *urb)
                }
 
                data->state = BCM203X_LOAD_FIRMWARE;
-
+               /* fall through */
        case BCM203X_LOAD_FIRMWARE:
                if (data->fw_sent == data->fw_size) {
                        usb_fill_int_urb(urb, udev, usb_rcvintpipe(udev, BCM203X_IN_EP),
index 424c15a..e2c078d 100644 (file)
@@ -242,7 +242,7 @@ static void ll_device_want_to_wakeup(struct hci_uart *hu)
                 * perfectly safe to always send one.
                 */
                BT_DBG("dual wake-up-indication");
-               /* deliberate fall-through - do not add break */
+               /* fall through */
        case HCILL_ASLEEP:
                /* acknowledge device wake up */
                if (send_hcill_cmd(HCILL_WAKE_UP_ACK, hu) < 0) {