tbm_bufmgr_sprd: clean up target_name() 47/97447/1
authorYoungJun Cho <yj44.cho@samsung.com>
Mon, 14 Nov 2016 06:49:23 +0000 (15:49 +0900)
committerYoungJun Cho <yj44.cho@samsung.com>
Mon, 14 Nov 2016 06:59:15 +0000 (15:59 +0900)
This patch cleans up target_name().
- Renames it as _target_name().

Change-Id: I93ac6144a99ae6937377b8fadf0d21e48675adab
Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
src/tbm_bufmgr_sprd.c

index db9236a..46c1372 100644 (file)
@@ -70,41 +70,39 @@ static int bDebug = 0;
 
 #define SPRD_DRM_NAME "sprd"
 
-char *
-target_name()
+static char *
+_target_name(void)
 {
-       FILE *f;
+       static char app_name[128] = {0, };
+       static int initialized = 0;
        char *slash;
-       static int     initialized = 0;
-       static char app_name[128];
+       FILE *f;
 
        if (initialized)
                return app_name;
 
        /* get the application name */
        f = fopen("/proc/self/cmdline", "r");
-
        if (!f)
-               return 0;
-
-       memset(app_name, 0x00, sizeof(app_name));
+               return NULL;
 
        if (fgets(app_name, 100, f) == NULL) {
                fclose(f);
-               return 0;
+               return NULL;
        }
 
        fclose(f);
 
-       if ((slash = strrchr(app_name, '/')) != NULL)
+       slash = strrchr(app_name, '/');
+       if (slash != NULL)
                memmove(app_name, slash + 1, strlen(slash));
 
        initialized = 1;
 
        return app_name;
 }
-#define TBM_SPRD_LOG(fmt, args...)        LOGE("\033[31m"  "[%s]" fmt "\033[0m", target_name(), ##args)
-#define DBG(fmt, args...)        if (bDebug&01) LOGE("[%s]" fmt, target_name(), ##args)
+#define TBM_SPRD_LOG(fmt, args...)        LOGE("\033[31m"  "[%s]" fmt "\033[0m", _target_name(), ##args)
+#define DBG(fmt, args...)        if (bDebug&01) LOGE("[%s]" fmt, _target_name(), ##args)
 #else
 #define TBM_SPRD_LOG(...)
 #define DBG(...)
@@ -409,7 +407,7 @@ _tbm_sprd_open_drm()
                                if (strcmp(udev_device_get_sysname(device_parent), "sprd-drm") == 0) {
                                        drm_device = device;
                                        DBG("[%s] Found render device: '%s' (%s)\n",
-                                           target_name(),
+                                           _target_name(),
                                            udev_device_get_syspath(drm_device),
                                            udev_device_get_sysname(device_parent));
                                        break;
@@ -1197,7 +1195,7 @@ tbm_sprd_bo_import_fd(tbm_bo bo, tbm_fd key)
        }
 
        DBG(" [%s] bo:%p, gem:%d(%d), fd:%d, key_fd:%d, flags:%d(%d), size:%d\n",
-            target_name(),
+            _target_name(),
             bo,
             bo_sprd->gem, bo_sprd->name,
             bo_sprd->dmabuf,
@@ -1258,7 +1256,7 @@ tbm_sprd_bo_export_fd(tbm_bo bo)
        }
 
        DBG(" [%s] bo:%p, gem:%d(%d), fd:%d, key_fd:%d, flags:%d(%d), size:%d\n",
-            target_name(),
+            _target_name(),
             bo,
             bo_sprd->gem, bo_sprd->name,
             bo_sprd->dmabuf,