scsi: scsi_transport_fc: Remove double FC_FPORT_DELETED in mask creation
authorDaniel Wagner <dwagner@suse.de>
Thu, 20 May 2021 07:31:27 +0000 (09:31 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 May 2021 20:58:02 +0000 (16:58 -0400)
Remove the double listed FC_FPORT_DELETING from the mask creation.

Commit 260f4aeddb48 ("scsi: scsi_transport_fc: return -EBUSY for deleted
vport") added VC_VPORT_DELETING to the flag masks. This is not necessary as
FC_FPORT_DEL is defined as VC_FPORT_DELETED | FC_FPORT_DELETING.

Link: https://lore.kernel.org/r/20210520073127.132456-1-dwagner@suse.de
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_fc.c

index da5b503..49748cd 100644 (file)
@@ -1686,7 +1686,7 @@ store_fc_vport_delete(struct device *dev, struct device_attribute *attr,
        unsigned long flags;
 
        spin_lock_irqsave(shost->host_lock, flags);
-       if (vport->flags & (FC_VPORT_DEL | FC_VPORT_CREATING | FC_VPORT_DELETING)) {
+       if (vport->flags & (FC_VPORT_DEL | FC_VPORT_CREATING)) {
                spin_unlock_irqrestore(shost->host_lock, flags);
                return -EBUSY;
        }