[wasm][debugger] Fixing step over in an async method (#42639)
authorThays Grazia <thaystg@gmail.com>
Thu, 24 Sep 2020 17:09:43 +0000 (14:09 -0300)
committerGitHub <noreply@github.com>
Thu, 24 Sep 2020 17:09:43 +0000 (14:09 -0300)
* Fixing step over in an async method.

* Removing debugstore change.

src/mono/mono/mini/debugger-engine.c
src/mono/wasm/debugger/DebuggerTestSuite/SteppingTests.cs

index c5964e0..a028ff8 100644 (file)
@@ -1323,8 +1323,11 @@ mono_de_ss_start (SingleStepReq *ss_req, SingleStepArgs *ss_args)
        } else {
                frame_index = 1;
 
+#ifndef TARGET_WASM
                if (ss_args->ctx && !frames) {
-
+#else
+               if (!frames) {
+#endif
                        mono_loader_lock ();
                        locked = TRUE;
 
index 16cfe82..e517b6d 100644 (file)
@@ -903,8 +903,7 @@ namespace DebuggerTests
             });
         }
 
-        // [Fact]
-        // [ActiveIssue("https://github.com/dotnet/runtime/issues/42424")]
+        [Fact]
         public async Task BreakOnAwaitThenStepOverToNextAwaitCall()
         {
             var insp = new Inspector();
@@ -927,8 +926,7 @@ namespace DebuggerTests
             });
         }
 
-        // [Fact]
-        // [ActiveIssue("https://github.com/dotnet/runtime/issues/42424")]
+        [Fact]
         public async Task BreakOnAwaitThenStepOverToNextLine()
         {
             var insp = new Inspector();