Improve readability

- Change testcase name from DBHandlerTest to ParserDBHandlerTest.
- Use abbreviate namespace.

Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>

diff --git a/test/unit_tests/test_parser_db_handlers.cc b/test/unit_tests/test_parser_db_handlers.cc
index b9a8979..6d5e768 100644 (file)
--- a/test/unit_tests/test_parser_db_handlers.cc
+++ b/test/unit_tests/test_parser_db_handlers.cc
@@ -36,34 +36,36 @@
 
 #define TEST_PARSER_DB "test.pkgmgr_parser.db"
 
-class CreateDBHandlerMock : public pkgmgr_server::database::CreateDBHandler {
+namespace psd = pkgmgr_server::database;
+
+class CreateDBHandlerMock : public psd::CreateDBHandler {
  public:
   CreateDBHandlerMock(uid_t uid, int pid)
-      : pkgmgr_server::database::CreateDBHandler(uid, pid) {}
+      : psd::CreateDBHandler(uid, pid) {}
 
   MOCK_METHOD0(Connect, bool());
   MOCK_METHOD0(GetConnection, std::vector<std::pair<sqlite3*, uid_t>>());
 };
 
-class PkgSetDBHandlerMock : public pkgmgr_server::database::PkgSetDBHandler {
+class PkgSetDBHandlerMock : public psd::PkgSetDBHandler {
  public:
-  PkgSetDBHandlerMock(uid_t uid, int pid) : pkgmgr_server::database::PkgSetDBHandler(uid, pid) {}
+  PkgSetDBHandlerMock(uid_t uid, int pid) : psd::PkgSetDBHandler(uid, pid) {}
 
   MOCK_METHOD0(Connect, bool());
   MOCK_METHOD0(GetConnection, std::vector<std::pair<sqlite3*, uid_t>>());
 };
 
-class PkgGetDBHandlerMock : public pkgmgr_server::database::PkgGetDBHandler {
+class PkgGetDBHandlerMock : public psd::PkgGetDBHandler {
  public:
-  PkgGetDBHandlerMock(uid_t uid, int pid) : pkgmgr_server::database::PkgGetDBHandler(uid, pid) {}
+  PkgGetDBHandlerMock(uid_t uid, int pid) : psd::PkgGetDBHandler(uid, pid) {}
 
   MOCK_METHOD0(Connect, bool());
   MOCK_METHOD0(GetConnection, std::vector<std::pair<sqlite3*, uid_t>>());
 };
 
-class AppInfoDBHandlerMock : public pkgmgr_server::database::AppInfoDBHandler {
+class AppInfoDBHandlerMock : public psd::AppInfoDBHandler {
  public:
-  AppInfoDBHandlerMock(uid_t uid, int pid) : pkgmgr_server::database::AppInfoDBHandler(uid, pid) {}
+  AppInfoDBHandlerMock(uid_t uid, int pid) : psd::AppInfoDBHandler(uid, pid) {}
 
   MOCK_METHOD0(Connect, bool());
   MOCK_METHOD0(GetConnection, std::vector<std::pair<sqlite3*, uid_t>>());
@@ -71,10 +73,10 @@ class AppInfoDBHandlerMock : public pkgmgr_server::database::AppInfoDBHandler {
 
 class Mocks : public ::testing::NiceMock<SystemInfoMock> {};
 
-class DBHandlerTest : public TestFixture {
+class ParserDBHandlerTest : public TestFixture {
  public:
-  DBHandlerTest() : TestFixture(std::make_unique<Mocks>()) {}
-  virtual ~DBHandlerTest() {}
+  ParserDBHandlerTest() : TestFixture(std::make_unique<Mocks>()) {}
+  virtual ~ParserDBHandlerTest() {}
 
   virtual void SetUp() {
     sqlite3 *db;
@@ -120,7 +122,7 @@ class DBHandlerTest : public TestFixture {
   std::vector<std::pair<sqlite3*, uid_t>> db_handles_;
 };
 
-TEST_F(DBHandlerTest, PkgSetDBHandlerTest) {
+TEST_F(ParserDBHandlerTest, PkgSetDBHandlerTest) {
   PkgSetDBHandlerMock pkg_set_db_handler(0, 0);
   pkg_set_db_handler.SetWriteType(pkgmgr_common::PkgWriteType::Insert);
   std::unique_ptr<package_x, decltype(pkgmgrinfo_basic_free_package)*> ptr(
@@ -133,7 +135,7 @@ TEST_F(DBHandlerTest, PkgSetDBHandlerTest) {
   ASSERT_EQ(pkg_set_db_handler.Execute(), 0);
 }
 
-TEST_F(DBHandlerTest, PkgGetDBHandlerTest) {
+TEST_F(ParserDBHandlerTest, PkgGetDBHandlerTest) {
   std::string pkgid = "pkgA";
   PkgSetDBHandlerMock pkg_set_db_handler(0, 0);
   pkg_set_db_handler.SetWriteType(pkgmgr_common::PkgWriteType::Insert);
@@ -177,7 +179,7 @@ TEST_F(DBHandlerTest, PkgGetDBHandlerTest) {
   ASSERT_EQ(IsEqualPackagesInfo(lpkginfo_list, rpkginfo_list), true);
 }
 
-TEST_F(DBHandlerTest, AppInfoDBHandlerTest) {
+TEST_F(ParserDBHandlerTest, AppInfoDBHandlerTest) {
   PkgSetDBHandlerMock pkg_set_db_handler(0, 0);
   pkg_set_db_handler.SetWriteType(pkgmgr_common::PkgWriteType::Insert);
   std::unique_ptr<package_x, decltype(pkgmgrinfo_basic_free_package)*> ptr(