ASoC: nuc900: Fix platform_get_irq's error checking
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Wed, 29 Nov 2017 16:17:12 +0000 (21:47 +0530)
committerMark Brown <broonie@kernel.org>
Fri, 1 Dec 2017 13:06:14 +0000 (13:06 +0000)
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/nuc900/nuc900-ac97.c

index b6615af..5e4fbd2 100644 (file)
@@ -346,8 +346,8 @@ static int nuc900_ac97_drvprobe(struct platform_device *pdev)
        }
 
        nuc900_audio->irq_num = platform_get_irq(pdev, 0);
-       if (!nuc900_audio->irq_num) {
-               ret = -EBUSY;
+       if (nuc900_audio->irq_num <= 0) {
+               ret = nuc900_audio->irq_num < 0 ? nuc900_audio->irq_num : -EBUSY;
                goto out;
        }