Close the socket if bind() fails (dotnet/corefx#36769)

When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.

Commit migrated from https://github.com/dotnet/corefx/commit/03ae543d4da4e539b9915a5f38f36a69739fa9d9

diff --git a/src/libraries/Native/Unix/System.Native/pal_networkchange.c b/src/libraries/Native/Unix/System.Native/pal_networkchange.c
index 822f7c8..dc1378c 100644 (file)
--- a/src/libraries/Native/Unix/System.Native/pal_networkchange.c
+++ b/src/libraries/Native/Unix/System.Native/pal_networkchange.c
@@ -35,7 +35,9 @@ Error SystemNative_CreateNetworkChangeListenerSocket(int32_t* retSocket)
     if (bind(sock, (struct sockaddr*)(&sa), sizeof(sa)) != 0)
     {
         *retSocket = -1;
-        return (Error)(SystemNative_ConvertErrorPlatformToPal(errno));
+        Error palError = (Error)(SystemNative_ConvertErrorPlatformToPal(errno));
+        close(sock);
+        return palError;
     }
 
     *retSocket = sock;