Fix invalid reads

Don't use a guint16* when getting a guint property via g_object_get()!

Bug #628323.

diff --git a/gio/gproxyaddressenumerator.c b/gio/gproxyaddressenumerator.c
index 7630897..29604dc 100644 (file)
--- a/gio/gproxyaddressenumerator.c
+++ b/gio/gproxyaddressenumerator.c
@@ -627,13 +627,16 @@ g_proxy_address_enumerator_set_property (GObject        *object,
                conn = g_network_address_parse_uri (uri, 0, NULL);
                if (conn)
                  {
+                   guint port;
+
                    priv->dest_uri = g_strdup (uri);
                    
                    g_object_get (conn,
                                  "hostname", &priv->dest_hostname,
-                                 "port", &priv->dest_port,
+                                 "port", &port,
                                  NULL);
 
+                   priv->dest_port = port;
                    g_object_unref (conn);
                  }
                else

diff --git a/gio/tests/network-address.c b/gio/tests/network-address.c
index 42b6079..e8cf513 100644 (file)
--- a/gio/tests/network-address.c
+++ b/gio/tests/network-address.c
@@ -4,7 +4,7 @@ static void
 test_basic (void)
 {
   GNetworkAddress *address;
-  guint16 port;
+  guint port;
   gchar *hostname;
 
   address = (GNetworkAddress*)g_network_address_new ("www.gnome.org", 8080);