Remove [GenerateConstructor] from IDL files

https://bugs.webkit.org/show_bug.cgi?id=77598

Reviewed by Adam Barth.

[GenerateConstructor] is used in some IDL files but it is not implemented
in code generators. I could not find any history about [GenerateConstructor]
in code generators. This patch removes them from IDL files.

Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
So simply removing them would make sense.

No new tests. No change in behavior.

* dom/DOMStringList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* webaudio/AudioPannerNode.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 2a4ca69..d070c12 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,26 @@
+2012-02-01  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [GenerateConstructor] from IDL files
+        https://bugs.webkit.org/show_bug.cgi?id=77598
+
+        Reviewed by Adam Barth.
+
+        [GenerateConstructor] is used in some IDL files but it is not implemented
+        in code generators. I could not find any history about [GenerateConstructor]
+        in code generators. This patch removes them from IDL files.
+
+        Maybe we want to replace [GenerateConstructor] with [Constructor] eventually,
+        but currently no tests are written for their constructors (e.g. "new DOMTokenList()").
+        So simply removing them would make sense.
+
+        No new tests. No change in behavior.
+
+        * dom/DOMStringList.idl:
+        * html/DOMSettableTokenList.idl:
+        * html/DOMTokenList.idl:
+        * svg/SVGFEConvolveMatrixElement.idl:
+        * webaudio/AudioPannerNode.idl:
+
 2012-02-01  Eric Carlson  <eric.carlson@apple.com>
 
         Consider user's preferred language when choosing text tracks

diff --git a/Source/WebCore/dom/DOMStringList.idl b/Source/WebCore/dom/DOMStringList.idl
index 43af825..8b37aaa 100644 (file)
--- a/Source/WebCore/dom/DOMStringList.idl
+++ b/Source/WebCore/dom/DOMStringList.idl
@@ -26,7 +26,6 @@
 module core {
 
     interface [
-        GenerateConstructor,
         HasIndexGetter
     ] DOMStringList {
         readonly attribute unsigned long length;

diff --git a/Source/WebCore/html/DOMSettableTokenList.idl b/Source/WebCore/html/DOMSettableTokenList.idl
index 6260623..02c6500 100644 (file)
--- a/Source/WebCore/html/DOMSettableTokenList.idl
+++ b/Source/WebCore/html/DOMSettableTokenList.idl
@@ -25,7 +25,6 @@
 module core {
 
     interface [
-        GenerateConstructor,
         HasIndexGetter,
         GenerateToJS
     ] DOMSettableTokenList : DOMTokenList {

diff --git a/Source/WebCore/html/DOMTokenList.idl b/Source/WebCore/html/DOMTokenList.idl
index f94491c..0bcc488 100644 (file)
--- a/Source/WebCore/html/DOMTokenList.idl
+++ b/Source/WebCore/html/DOMTokenList.idl
@@ -26,7 +26,6 @@ module core {
 
     interface [
         GenerateIsReachable=ImplElementRoot,
-        GenerateConstructor,
         HasIndexGetter
     ] DOMTokenList {
         readonly attribute unsigned long length;

diff --git a/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl b/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
index 5fdc55c..d880aa7 100644 (file)
--- a/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
+++ b/Source/WebCore/svg/SVGFEConvolveMatrixElement.idl
@@ -27,7 +27,6 @@ module svg {
 
     interface [
         Conditional=SVG&FILTERS,
-        GenerateConstructor,
         DontCheckEnums
     ] SVGFEConvolveMatrixElement : SVGElement,
                                    SVGFilterPrimitiveStandardAttributes {

diff --git a/Source/WebCore/webaudio/AudioPannerNode.idl b/Source/WebCore/webaudio/AudioPannerNode.idl
index 2db093d..2abe53a 100644 (file)
--- a/Source/WebCore/webaudio/AudioPannerNode.idl
+++ b/Source/WebCore/webaudio/AudioPannerNode.idl
@@ -25,7 +25,6 @@
 module audio {
     interface [
         Conditional=WEB_AUDIO,
-        GenerateConstructor,
         GenerateToJS
     ] AudioPannerNode : AudioNode {
         // Panning model