drm/amd/display: add dsc mst stream pbn log for debug
authorHersen Wu <hersenwu@amd.com>
Sun, 6 Feb 2022 21:06:00 +0000 (16:06 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 16 Feb 2022 22:12:00 +0000 (17:12 -0500)
[why]
payload and slot number of display on dsc mst hub will be
adjusted when there is change on any display on dsc hub.
to monitor dsc enable/disable, pbn change, we need add log.

[How]
add mst_pbn to dc_dsc_config of dc_crtc_timing.
add dsc, pbn, display name within dc_core_enable_stream,
dc_core_disable_stream, dc_stream_log

Reviewed-by: Jerry Zuo <Jerry.Zuo@amd.com>
Acked-by: Jasdeep Dhillon <jdhillon@amd.com>
Signed-off-by: Hersen Wu <hersenwu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
drivers/gpu/drm/amd/display/dc/core/dc_link.c
drivers/gpu/drm/amd/display/dc/core/dc_stream.c
drivers/gpu/drm/amd/display/dc/dc_hw_types.h

index 0e58c1a..9305630 100644 (file)
@@ -599,6 +599,21 @@ static void set_dsc_configs_from_fairness_vars(struct dsc_mst_fairness_params *p
                } else {
                        params[i].timing->flags.DSC = 0;
                }
+               params[i].timing->dsc_cfg.mst_pbn = vars[i + k].pbn;
+       }
+
+       for (i = 0; i < count; i++) {
+               if (params[i].sink) {
+                       if (params[i].sink->sink_signal != SIGNAL_TYPE_VIRTUAL &&
+                               params[i].sink->sink_signal != SIGNAL_TYPE_NONE)
+                               DRM_DEBUG_DRIVER("%s i=%d dispname=%s\n", __func__, i,
+                                       params[i].sink->edid_caps.display_name);
+               }
+
+               DRM_DEBUG_DRIVER("dsc=%d bits_per_pixel=%d pbn=%d\n",
+                       params[i].timing->flags.DSC,
+                       params[i].timing->dsc_cfg.bits_per_pixel,
+                       vars[i + k].pbn);
        }
 }
 
index b171860..48858e3 100644 (file)
@@ -4082,6 +4082,15 @@ void core_link_enable_stream(
 
        DC_LOGGER_INIT(pipe_ctx->stream->ctx->logger);
 
+       if (pipe_ctx->stream->sink) {
+               if (pipe_ctx->stream->sink->sink_signal != SIGNAL_TYPE_VIRTUAL &&
+                       pipe_ctx->stream->sink->sink_signal != SIGNAL_TYPE_NONE) {
+                       DC_LOG_DC("%s pipe_ctx dispname=%s signal=%x\n", __func__,
+                       pipe_ctx->stream->sink->edid_caps.display_name,
+                       pipe_ctx->stream->signal);
+               }
+       }
+
        if (!IS_DIAG_DC(dc->ctx->dce_environment) &&
                        dc_is_virtual_signal(pipe_ctx->stream->signal))
                return;
@@ -4303,6 +4312,17 @@ void core_link_disable_stream(struct pipe_ctx *pipe_ctx)
        if (is_dp_128b_132b_signal(pipe_ctx))
                vpg = pipe_ctx->stream_res.hpo_dp_stream_enc->vpg;
 
+       DC_LOGGER_INIT(pipe_ctx->stream->ctx->logger);
+
+       if (pipe_ctx->stream->sink) {
+               if (pipe_ctx->stream->sink->sink_signal != SIGNAL_TYPE_VIRTUAL &&
+                       pipe_ctx->stream->sink->sink_signal != SIGNAL_TYPE_NONE) {
+                       DC_LOG_DC("%s pipe_ctx dispname=%s signal=%x\n", __func__,
+                       pipe_ctx->stream->sink->edid_caps.display_name,
+                       pipe_ctx->stream->signal);
+               }
+       }
+
        if (!IS_DIAG_DC(dc->ctx->dce_environment) &&
                        dc_is_virtual_signal(pipe_ctx->stream->signal))
                return;
index 57cf4cb..263f989 100644 (file)
@@ -737,5 +737,21 @@ void dc_stream_log(const struct dc *dc, const struct dc_stream_state *stream)
        DC_LOG_DC(
                        "\tlink: %d\n",
                        stream->link->link_index);
+
+       DC_LOG_DC(
+                       "\tdsc: %d, mst_pbn: %d\n",
+                       stream->timing.flags.DSC,
+                       stream->timing.dsc_cfg.mst_pbn);
+
+       if (stream->sink) {
+               if (stream->sink->sink_signal != SIGNAL_TYPE_VIRTUAL &&
+                       stream->sink->sink_signal != SIGNAL_TYPE_NONE) {
+
+                       DC_LOG_DC(
+                                       "\tdispname: %s signal: %x\n",
+                                       stream->sink->edid_caps.display_name,
+                                       stream->signal);
+               }
+       }
 }
 
index eac34f5..c964f59 100644 (file)
@@ -745,6 +745,7 @@ struct dc_dsc_config {
        bool is_frl; /* indicate if DSC is applied based on HDMI FRL sink's capability */
 #endif
        bool is_dp; /* indicate if DSC is applied based on DP's capability */
+       uint32_t mst_pbn; /* pbn of display on dsc mst hub */
 };
 struct dc_crtc_timing {
        uint32_t h_total;