regulator: sc2731: Fix defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE
authorAxel Lin <axel.lin@ingics.com>
Mon, 1 Jan 2018 12:38:50 +0000 (20:38 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 3 Jan 2018 12:10:14 +0000 (12:10 +0000)
The defines for SC2731_WR_UNLOCK and SC2731_PWR_WR_PROT_VALUE makes
regmap_write() call looks strange because it takes reg parameter fist
then val.
Base on Erick's suggestion to define SC2731_PWR_WR_PROT and
SC2731_WR_UNLOCK_VALUE instead.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Erick Chen <erick.chen@spreadtrum.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/sc2731-regulator.c

index 794fcd5..eb2bdf0 100644 (file)
@@ -13,8 +13,8 @@
 /*
  * SC2731 regulator lock register
  */
-#define SC2731_PWR_WR_PROT_VALUE       0xf0c
-#define SC2731_WR_UNLOCK               0x6e7f
+#define SC2731_PWR_WR_PROT             0xf0c
+#define SC2731_WR_UNLOCK_VALUE         0x6e7f
 
 /*
  * SC2731 enable register
@@ -203,8 +203,8 @@ static struct regulator_desc regulators[] = {
 
 static int sc2731_regulator_unlock(struct regmap *regmap)
 {
-       return regmap_write(regmap, SC2731_PWR_WR_PROT_VALUE,
-                           SC2731_WR_UNLOCK);
+       return regmap_write(regmap, SC2731_PWR_WR_PROT,
+                           SC2731_WR_UNLOCK_VALUE);
 }
 
 static int sc2731_regulator_probe(struct platform_device *pdev)