mac80211: Fix MLO address translation for multiple bss case
authorSriram R <quic_srirrama@quicinc.com>
Thu, 8 Dec 2022 04:00:50 +0000 (09:30 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 10 Jan 2023 12:24:26 +0000 (13:24 +0100)
When multiple interfaces are present in the local interface
list, new skb copy is taken before rx processing except for
the first interface. The address translation happens each
time only on the original skb since the hdr pointer is not
updated properly to the newly created skb.

As a result frames start to drop in userspace when address
based checks or search fails.

Signed-off-by: Sriram R <quic_srirrama@quicinc.com>
Link: https://lore.kernel.org/r/20221208040050.25922-1-quic_srirrama@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c

index c518287b2356bdcee35ae6486fbcbbfb2fbbf82d..c6562a6d25035765a4c0d7cb353da894afbbbaed 100644 (file)
@@ -4838,6 +4838,9 @@ static bool ieee80211_prepare_and_rx_handle(struct ieee80211_rx_data *rx,
                 */
                shwt = skb_hwtstamps(rx->skb);
                shwt->hwtstamp = skb_hwtstamps(skb)->hwtstamp;
+
+               /* Update the hdr pointer to the new skb for translation below */
+               hdr = (struct ieee80211_hdr *)rx->skb->data;
        }
 
        if (unlikely(rx->sta && rx->sta->sta.mlo)) {