echo-cancel: Fix speex echo state setting
authorArun Raghavan <arun@arunraghavan.net>
Mon, 15 May 2017 08:47:08 +0000 (14:17 +0530)
committerArun Raghavan <arun@arunraghavan.net>
Tue, 24 Oct 2017 17:03:23 +0000 (22:33 +0530)
The state should be set even if echo suppression is disabled, which is
not currently the case.

src/modules/echo-cancel/speex.c

index a3ae646..bbf059f 100644 (file)
@@ -128,11 +128,11 @@ static bool pa_speex_ec_preprocessor_init(pa_echo_canceller *ec, pa_sample_spec
                 speex_preprocess_ctl(ec->params.speex.pp_state, SPEEX_PREPROCESS_SET_ECHO_SUPPRESS_ACTIVE,
                                      &echo_suppress_attenuation_active);
             }
-
-            speex_preprocess_ctl(ec->params.speex.pp_state, SPEEX_PREPROCESS_SET_ECHO_STATE,
-                                 ec->params.speex.state);
         }
 
+        speex_preprocess_ctl(ec->params.speex.pp_state, SPEEX_PREPROCESS_SET_ECHO_STATE,
+                             ec->params.speex.state);
+
         pa_log_info("Loaded speex preprocessor with params: agc=%s, denoise=%s, echo_suppress=%s", pa_yes_no(agc),
                     pa_yes_no(denoise), pa_yes_no(echo_suppress));
     } else