projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
23d775f
)
sfc: don't unregister flow_indr if it was never registered
author
Edward Cree
<ecree.xilinx@gmail.com>
Tue, 15 Aug 2023 15:57:27 +0000
(16:57 +0100)
committer
Jakub Kicinski
<kuba@kernel.org>
Thu, 17 Aug 2023 18:31:07 +0000
(11:31 -0700)
In efx_init_tc(), move the setting of efx->tc->up after the
flow_indr_dev_register() call, so that if it fails, efx_fini_tc()
won't call flow_indr_dev_unregister().
Fixes:
5b2e12d51bd8
("sfc: bind indirect blocks for TC offload on EF100")
Suggested-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Link:
https://lore.kernel.org/r/a81284d7013aba74005277bd81104e4cfbea3f6f.1692114888.git.ecree.xilinx@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/tc.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/sfc/tc.c
b/drivers/net/ethernet/sfc/tc.c
index
15ebd39
..
fe268b6
100644
(file)
--- a/
drivers/net/ethernet/sfc/tc.c
+++ b/
drivers/net/ethernet/sfc/tc.c
@@
-1657,10
+1657,10
@@
int efx_init_tc(struct efx_nic *efx)
rc = efx_tc_configure_fallback_acts_reps(efx);
if (rc)
return rc;
- efx->tc->up = true;
rc = flow_indr_dev_register(efx_tc_indr_setup_cb, efx);
if (rc)
return rc;
+ efx->tc->up = true;
return 0;
}