spi: qup: replace spin_lock_irqsave by spin_lock in hard IRQ
authorXingbang Liu <liu.airalert@gmail.com>
Wed, 2 Mar 2022 07:15:21 +0000 (15:15 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 13:16:08 +0000 (13:16 +0000)
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.

Signed-off-by: Xingbang Liu <liu.airalert@gmail.com>
Link: https://lore.kernel.org/r/20220302071521.6638-1-liu.airalert@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c

index d39dec6..00d6084 100644 (file)
@@ -593,7 +593,6 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id)
 {
        struct spi_qup *controller = dev_id;
        u32 opflags, qup_err, spi_err;
-       unsigned long flags;
        int error = 0;
 
        qup_err = readl_relaxed(controller->base + QUP_ERROR_FLAGS);
@@ -625,10 +624,10 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id)
                error = -EIO;
        }
 
-       spin_lock_irqsave(&controller->lock, flags);
+       spin_lock(&controller->lock);
        if (!controller->error)
                controller->error = error;
-       spin_unlock_irqrestore(&controller->lock, flags);
+       spin_unlock(&controller->lock);
 
        if (spi_qup_is_dma_xfer(controller->mode)) {
                writel_relaxed(opflags, controller->base + QUP_OPERATIONAL);