[mono] Resolve failing tests on apple mobile platforms (#90515)
authorMilos Kotlar <kotlarmilos@gmail.com>
Mon, 14 Aug 2023 13:56:44 +0000 (15:56 +0200)
committerGitHub <noreply@github.com>
Mon, 14 Aug 2023 13:56:44 +0000 (15:56 +0200)
* Don't run arm64 jobs

* Disable failing jobs

* Fix failing calendar test

eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectory.Stream.Tests.cs
src/libraries/System.Formats.Tar/tests/TarFile/TarFile.ExtractToDirectoryAsync.Stream.Tests.cs
src/libraries/System.Globalization.Calendars/tests/System/Globalization/CalendarTestBase.cs

index a0b5fe9..c7bcfc1 100644 (file)
@@ -60,7 +60,9 @@ jobs:
     platforms:
       - iossimulator_x64
       - tvossimulator_x64
-      - iossimulator_arm64
+      # don't run tests on arm64 PRs until we can get significantly more devices
+      - ${{ if eq(variables['isRollingBuild'], true) }}:
+        - iossimulator_arm64
     variables:
       - ${{ if and(eq(variables['System.TeamProject'], 'public'), eq(variables['Build.Reason'], 'PullRequest')) }}:
         - name: _HelixSource
@@ -105,7 +107,9 @@ jobs:
     platforms:
       - iossimulator_x64
       - tvossimulator_x64
-      - iossimulator_arm64
+      # don't run tests on arm64 PRs until we can get significantly more devices
+      - ${{ if eq(variables['isRollingBuild'], true) }}:
+        - iossimulator_arm64
     variables:
       - ${{ if and(eq(variables['System.TeamProject'], 'public'), eq(variables['Build.Reason'], 'PullRequest')) }}:
         - name: _HelixSource
index 47dce10..8bd60b6 100644 (file)
@@ -276,6 +276,7 @@ namespace System.Formats.Tar.Tests
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/88049", TestPlatforms.iOS | TestPlatforms.tvOS)]
         public void ExtractToDirectory_ExactRootDirMatch_Directory_Relative_Throws()
         {
             string entryFolderName = "folder";
index d287c6a..4a16376 100644 (file)
@@ -341,6 +341,7 @@ namespace System.Formats.Tar.Tests
         }
 
         [Fact]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/88049", TestPlatforms.iOS | TestPlatforms.tvOS)]
         public async Task ExtractToDirectory_ExactRootDirMatch_Directory_Relative_Throws_Async()
         {
             string entryFolderName = "folder";
index 061d071..0d67b2e 100644 (file)
@@ -430,7 +430,7 @@ namespace System.Globalization.Tests
             Assert.All(DateTime_TestData(calendar), dt =>
             {
                 // JapaneseCalendar throws on ICU, but not on NLS or in HybridGlobalization on Browser
-                if ((calendar is JapaneseCalendar && (PlatformDetection.IsNlsGlobalization || PlatformDetection.IsHybridGlobalizationOnBrowser)) || calendar is HebrewCalendar || calendar is TaiwanLunisolarCalendar || calendar is JapaneseLunisolarCalendar)
+                if ((calendar is JapaneseCalendar && (PlatformDetection.IsNlsGlobalization || PlatformDetection.IsHybridGlobalizationOnBrowser || PlatformDetection.IsHybridGlobalizationOnOSX)) || calendar is HebrewCalendar || calendar is TaiwanLunisolarCalendar || calendar is JapaneseLunisolarCalendar)
                 {
                     calendar.GetEra(dt);
                 }