Remove unnecessary shared_ptr 38/316038/1
authorKrzysztof Malysa <k.malysa@samsung.com>
Mon, 9 Dec 2024 14:18:00 +0000 (15:18 +0100)
committerKrzysztof Malysa <k.malysa@samsung.com>
Mon, 9 Dec 2024 15:14:37 +0000 (16:14 +0100)
Change-Id: Iacd2ab49b089cd21c30d3f725b3966e15f901b94

srcs/client/client-request.h

index ee58a0815e6231ee232ad4126d66b916bc5996b3..4f74d180ffaa6dec684457ec04bf3ca7e9293b78 100644 (file)
@@ -219,7 +219,7 @@ public:
 };
 
 template <typename Request>
-void cb_worker(std::shared_ptr<Request> request, const typename Request::Callbacks &callbacks)
+void cb_worker(std::unique_ptr<Request> request, const typename Request::Callbacks &callbacks)
 {
     static constexpr const char *REQUEST_KIND_PREFIX =
          std::is_same_v<typename Request::Callbacks, wauthn_mc_callbacks_s> ? "MC: " : "GA: ";
@@ -276,7 +276,7 @@ int wauthn_process(const wauthn_client_data_s *client_data,
                 "because options->linked_device not null");
             callbacks->qrcode_callback = nullptr;
         }
-        std::shared_ptr<T> request = std::make_shared<T>();
+        std::unique_ptr<T> request = std::make_unique<T>();
         int ret = request->Init();
         if (ret != WAUTHN_ERROR_NONE)
             return ret;
@@ -287,7 +287,7 @@ int wauthn_process(const wauthn_client_data_s *client_data,
             return request->GetStatus();
         LogInfo("SendRequest: " << get_error_message(request->GetStatus()));
 
-        std::thread worker([request = std::move(request), callbacks = *callbacks] {
+        std::thread worker([request = std::move(request), callbacks = *callbacks]() mutable {
             cb_worker(std::move(request), callbacks);
         });
         worker.detach();