playsinkconvertbin: No need to remove the identity
authorThiago Santos <thiago.sousa.santos@collabora.com>
Mon, 17 Oct 2011 22:41:49 +0000 (22:41 +0000)
committerSebastian Dröge <sebastian.droege@collabora.co.uk>
Thu, 3 Nov 2011 09:02:58 +0000 (10:02 +0100)
The identity element should be handled by the GstBin's cleanup,
removing it on the remove_elements function might remove it
too soon, as this function can be called directly from playsink

gst/playback/gstplaysinkconvertbin.c

index 4648d67..7c1bb68 100644 (file)
@@ -399,11 +399,6 @@ gst_play_sink_convert_bin_remove_elements (GstPlaySinkConvertBin * self)
     g_list_free (self->conversion_elements);
     self->conversion_elements = NULL;
   }
-  if (self->identity) {
-    gst_element_set_state (self->identity, GST_STATE_NULL);
-    gst_bin_remove (GST_BIN_CAST (self), self->identity);
-    self->identity = NULL;
-  }
   if (self->converter_caps) {
     gst_caps_unref (self->converter_caps);
     self->converter_caps = NULL;